| Summary: | Change get_*_registry to make_*_registry in def resources | ||
|---|---|---|---|
| Product: | TAO | Reporter: | Ossama Othman <ossama.othman> |
| Component: | ORB | Assignee: | Ossama Othman <ossama.othman> |
| Status: | RESOLVED --- | ||
| Severity: | trivial | ||
| Priority: | P3 | ||
| Version: | 1.0 | ||
| Hardware: | All | ||
| OS: | All | ||
I'll take it. The ORB_Core "TAO_OC_RETRIEVE" macro expects a function to begin with "get," meaning that changing the names to start with "make" will break code. I really don't want to play with the macros, nor do I want to break code so I'll leave things as they are (relunctantly). |
We should use make{acceptor,connector}_registry instead of get_{acceptor,connector}_registry in default_resources.cpp to be more consistent with a factory pattern. "get" implies obtaining a pointer to an object, whereas "make" implies *creation* of an object, which is what is occuring.