Bug 1933

Summary:	Incomplete implementation of freebuf() for reference types.
Product:	TAO	Reporter:	Carlos O'Ryan <coryan>
Component:	ORB	Assignee:	Johnny Willemsen <jwillemsen>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P3
Version:	1.4.2
Hardware:	All
OS:	All
Bug Depends on:
Bug Blocks:	1929

Description Carlos O'Ryan 2004-09-19 20:03:30 CDT

The CORBA C++ mapping (I am looking at formal/03-06-03, page 1-39 and forward)
requires the freebuf() function to call:

1) The destructor of each element (for sequences of self-managed types.)
2) CORBA::release() for each element in a sequence of object references.
3) CORBA::string_free() or CORBA::wstring_free() for each element in a sequence
of strings or wide-strings, as it corresponds.

TAO's version does not do this.

Comment 1 Carlos O'Ryan 2004-09-19 20:03:54 CDT

Yet another sequence bug.

Comment 2 Carlos O'Ryan 2004-09-20 18:07:51 CDT

I think "reference type" is more descriptive than "not self-managed."

Comment 3 Johnny Willemsen 2006-03-06 06:22:54 CST

not fixed with sequence update

Comment 4 Carlos O'Ryan 2006-03-06 08:08:18 CST

I think this problem *is* fixed by the new sequence implementation.  Look at the
code for generic_sequence<>::freebuf() it delegates on the allocation traits. 
Then look at, for example, unbounded_reference_allocation_traits<>::freebuf():
it calls release_range() to release each element.

I event think there are unit tests for this stuff.

Comment 5 Johnny Willemsen 2006-03-06 08:12:45 CST

ok, will check this. in an old overview of you I found a remark not fixed. When
the repo is open I will commit sequpdate3 branch, will be x.5 with sequence
changes added.

Comment 6 Johnny Willemsen 2006-03-06 08:13:55 CST

taking over

Comment 7 Johnny Willemsen 2006-03-06 08:14:07 CST

accept

Comment 8 Johnny Willemsen 2006-04-19 07:29:00 CDT

Wed Apr 19 07:48:12 UTC 2006  Johnny Willemsen  <jwillemsen@remedy.nl>