Bug 2085

Summary:	CORBA::ORB::string_to_object() should raise exceptions
Product:	TAO	Reporter:	fp
Component:	ORB	Assignee:	DOC Center Support List (internal) <tao-support>
Status:	ASSIGNED ---
Severity:	normal	CC:	fp
Priority:	P3
Version:	1.6.4
Hardware:	All
OS:	All
Bug Depends on:
Bug Blocks:	1278

Description fp 2005-04-07 09:35:27 CDT

I haven't checked all code locations, but it looks as if the ORB's
string_to_object() operation returns CORBA::Object::_nil() in most
failure scenarios, e.g., in CORBANAME_Parser.cpp and
CORBALOC_Parser.cpp.

I expect string_to_object() to fail with a BAD_PARAM exception in
case of failure. See, e.g., section 13.6.10.

Comment 1 Johnny Willemsen 2005-04-08 01:47:07 CDT

Added blocks and accept for tao-users

Comment 2 Johnny Willemsen 2006-04-13 09:19:16 CDT

to Kees

Comment 3 Johnny Willemsen 2007-04-17 13:45:09 CDT

to pool

Comment 4 Johnny Willemsen 2008-05-16 14:07:10 CDT

Accept, this bug is valid, TAO doesn't comply to the corba spec. Made a reproducer test program, we do need to add test strings with their expected minor code. Frank, do you have invalid strings with the minor code you do expect then?

Comment 5 Johnny Willemsen 2008-05-19 09:31:16 CDT

Mon May 19 14:29:21 UTC 2008  Johnny Willemsen  <jwillemsen@remedy.nl>

        * tests/Bug_2085_Regression/*:
          New regression test for the fact that string_to_object doesn't
          return an exception. Thanks to Frank Pilhofer <fpilhofe at mc dot com>
          for reporting this.

Comment 6 fp 2008-05-27 08:50:53 CDT

Sorry, I don't have any specific test cases.  When I ran across this, I just noticed that string_to_object() returned nil, and that its errors were not caught by my exception handling code.  So a very simple test case would be along the lines of

  try {
    obj = orb->string_to_object ("bazong");
    test_failed();
  }
  catch (const CORBA::BAD_PARAM &) {
    test_passed();
  }
  catch (...) {
    test_failed();
  }

Comment 7 Johnny Willemsen 2008-06-13 14:09:33 CDT

I have a test like this, but it needs to be more specific, which minor code do you expect (7, 8, 9 or 10) with which strings