Bug 2354

Summary:	Should throw exception with correct minor code when valuefactory is not found
Product:	TAO	Reporter:	Johnny Willemsen <jwillemsen>
Component:	ORB	Assignee:	Johnny Willemsen <jwillemsen>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P3
Version:	1.4.8
Hardware:	All
OS:	All
Bug Depends on:
Bug Blocks:	1278

Description Johnny Willemsen 2006-01-07 06:07:11 CST

Seems not to be in TAO, see 5.4.3 of the CORBA spec. We don't throw an exception
so far as I can tell, we just log an error.

Each language mapping specifies how and when the registration occurs, both explicit
and implicit. The registration must occur before an attempt is made to unmarshal an
instance of a value type. If the ORB is unable to locate and use the appropriate
factory,
then a MARSHAL exception with standard minor code 1 is raised.

Comment 1 Johnny Willemsen 2006-01-07 07:41:58 CST

Have to correct this, we do throw a marshal exception, but with minor code 0, not 1.

Comment 2 Johnny Willemsen 2006-01-08 13:37:25 CST

I think we should throw from the method below

CORBA::ValueBase::_tao_unmarshal_pre

This is called with the following stack:

003C56DC CORBA::ValueBase::_tao_unmarshal_pre(strm=:0012DFC8, factory=:0012D7DC,
valuetype=:0012D7AC, repo_id=:007FAF8E)
007E884F Messaging::ExceptionHolder::_tao_unmarshal(strm=:0012DFC8,
new_object=:0012D93C)
007E8D3E operator >>(strm=:0012DFC8, _tao_valuetype=:0012D93C)
0040CB81 TAO::In_Object_SArgument_T<Messaging::ExceptionHolder *,
TAO_Value_Var_T<Messaging::ExceptionHolder>,
TAO::Any_Insert_Policy_Stream<Messaging::ExceptionHolder *>
>::demarshal(this=:0012D924, cdr=:0012DFC8)
0078E8ED TAO::Upcall_Wrapper::pre_upcall(this=:0012D8DC, cdr=:0012DFC8,
args=:0012D8E8, nargs=2)

Now the exception is coming from pre_upcall, but then with the incorrect minor
code, we can only do it from the method above when we have native c++ exceptions
because the operator >> doesn't have environment arguments.

Comment 3 Johnny Willemsen 2006-01-09 02:59:25 CST

updated summary

Comment 4 Johnny Willemsen 2006-01-09 03:25:39 CST

The patch below would fix this, but at this point in the code we don't know if
the invocation completed or not. The exception can occur when unmarshaling the
valuetype in the server when it is received, and in the client, when we
unmarshal a valuetype as out or return type. Need to see how we could address that.

Index: ValueBase.cpp
===================================================================
RCS file:
/project/cvs-repository/ACE_wrappers-repository/TAO/tao/Valuetype/ValueBase.cpp,v
retrieving revision 1.30
diff -u -u -r1.30 ValueBase.cpp
--- ValueBase.cpp	6 Jan 2006 19:03:09 -0000	1.30
+++ ValueBase.cpp	9 Jan 2006 09:22:07 -0000
@@ -175,7 +175,6 @@
   //  new_object->_tao_unmarshal_v ()
   //  new_object->_tao_unmarshal_post ()
 
-//  CORBA::ValueBase *base = 0;
   CORBA::ValueFactory_var factory;
   CORBA::Boolean retval =
     CORBA::ValueBase::_tao_unmarshal_pre (strm,
@@ -348,10 +347,15 @@
 
   if (factory == 0) // %! except.!
     {
-      ACE_ERROR ((LM_ERROR,
-                  ACE_TEXT ("(%N:%l) ERROR: OBV factory is null for <%s>!\n"),
-                  repo_id));
-      return false;
+      if (TAO_debug_level > 0)
+        {
+          ACE_ERROR ((LM_ERROR,
+                      ACE_TEXT ("(%N:%l) ERROR: OBV factory is null for <%s>!\n"),
+                      repo_id));
+        }
+      ACE_THROW_RETURN (CORBA::MARSHAL (CORBA::OMGVMCID | 1,
+                                        CORBA::COMPLETED_YES),
+                                        false);
     }
 
   return retval;

Comment 5 Johnny Willemsen 2006-01-09 04:49:09 CST

added block

Comment 6 Johnny Willemsen 2006-01-09 09:21:12 CST

reassign

Comment 7 Johnny Willemsen 2006-01-13 05:43:59 CST

Fri Jan 13 11:43:12 UTC 2006  Johnny Willemsen  <jwillemsen@remedy.nl>

        * tao/Valuetype/ValueBase.cpp:
          When no OBV Factory is found, throw a MARSHAL exception with
          minor code 1 and completed MAYBE. This fixes bugzilla bug
          2354