| Summary: | [marshal/unmarshal valuetype sequence] bad any returned from Codec::decode | ||
|---|---|---|---|
| Product: | TAO | Reporter: | sdjiangwei |
| Component: | ORB | Assignee: | DOC Center Support List (internal) <tao-support> |
| Status: | ASSIGNED --- | ||
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 1.6.5 | ||
| Hardware: | All | ||
| OS: | All | ||
Failure can be confirmed, regression is also going into cvs. callstack is below,
lenght of the string is not correct.
00441084 ACE_InputCDR::read_string(this=:0012FD7C, x=:00C9B634)
0043F27E operator >>(is=:0012FD7C, x=:00C9B634)
0057757E operator >>(is=:0012FD7C, x=:00C9B634)
00406003 OBV_Value::_tao_unmarshal_state(this=:00C9B61C, strm=:0012FD7C,
ci=:0012FC68)
004050E5 OBV_Value::_tao_unmarshal__Value(this=:00C9B61C, strm=:0012FD7C,
ci=:0012FC68)
0040462B Value::_tao_unmarshal_v(this=:00C9B658, strm=:0012FD7C)
00403F93 Base::_tao_unmarshal(strm=:0012FD7C, new_object=:00C9A3F4)
00405C0A operator >>(strm=:0012FD7C, _tao_valuetype=:00C9A3F4)
00405E36 TAO::demarshal_sequence<TAO_InputCDR, Base, TAO_Value_Var_T<Base>
>(strm=:0012FD7C, target=:00C9A3A0)
00405D7A operator >>(strm=:0012FD7C, _tao_sequence=:00C9A3A0)
00405B9D TAO::Any_Dual_Impl_T<BaseSeq>::demarshal_value(this=:00C9A3B4,
cdr=:0012FD7C)
004058FB TAO::Any_Dual_Impl_T<BaseSeq>::extract(any=:00C99F34,
destructor=:0040440C, tc=:00409668, _tao_elem=:0012FE0C)
00405635 operator >>=(_tao_any=:00C99F34, _tao_elem=:0012FE0C)
004015AD ace_main_i(argc=1, argv=:00C7B950)
00402F26 ACE_Main::run_i(this=:0012FF88, argc=1, argv=:00C7B950)
00485E19 ACE_Main_Base::run(this=:0012FF88, argc=1, argv=:00C7B950)
00485E72 ace_os_main_i(mbase=:0012FF88, argc=1, argv=:00C7B950)
004011BF main(argc=1, argv=:00C7B950)
btw, please don't use asserts and iostreams, this will cause us problems on the embedded platforms. use ACE_ERROR/ACE_DEBUG instead When I put instead of an OBV_Value an OBV_Base into the sequence element then the extract works. the read_string seems to be outside the message block size Problem seems to be in the code below from Any_Unknown_IDL_Type.cpp. The
perform_skip seems to just take the length of the Base type, not of the Value.
The length of the data copied is in this case 32, the end is at offset 120, but
the full mb is 145. When I manually increase in the debugger the size from 32 to
57 then the decode itself works perfect.
void
TAO::Unknown_IDL_Type::_tao_decode (TAO_InputCDR &cdr
ACE_ENV_ARG_DECL)
{
// @@ (JP) The following code depends on the fact that
// TAO_InputCDR does not contain chained message blocks,
// otherwise <begin> and <end> could be part of
// different buffers!
// This will be the start of a new message block.
char *begin = cdr.rd_ptr ();
// Skip over the next argument.
TAO::traverse_status status =
TAO_Marshal_Object::perform_skip (this->type_,
&cdr
ACE_ENV_ARG_PARAMETER);
ACE_CHECK;
if (status != TAO::TRAVERSE_CONTINUE)
{
ACE_THROW (CORBA::MARSHAL ());
}
// This will be the end of the new message block.
char *end = cdr.rd_ptr ();
Problem seems in the method below, here when the sequence has members we always
skip for the exact size of the sequence element as declared, which is the base
size, not of a possible unknown size when it contains valuetypes.
TAO::traverse_status
TAO_Marshal_Sequence::skip (CORBA::TypeCode_ptr tc,
TAO_InputCDR *stream
ACE_ENV_ARG_DECL)
{
I wouldn't call this a problem - it's the way these operators are supposed to behave. They are not supposed to have any kind of polymorphic behavior, they are to be overloaded for each type, related by inheritance or not. After the codec has done its work, calling the demarshal virtual method on the sequence element goes to the derived type, but it is too late, the decoded stream is corrupted, as you say. >I wouldn't call this a problem - it's the way these operators are supposed to
>behave. They are not supposed to have any kind of polymorphic behavior, they
>are to be overloaded for each type, related by inheritance or not.
I don't agree you about this point.
I tested it on omniORB4.1.0beta2, it works fine.
If no polymorphic behavior, sequence for Abstrict valuetype is useless.
Have you tried to send the sequence on the wire between the client/server? Does that work? I think this is just related to the Any handling, not the marshaling itself Yes, I did.It works perfect. >Yes, I did.It works perfect.
I did it with omniORB4.1.0beta2 . It works perfect.
I will try it with TAO
Could you maybe as example make a small app where you send this sequence between client and server? // -*- MPC -*-
project(client) : taoclient, valuetype {
Source_Files {
client.cpp
TestC.cpp
}
}
project(server) : taoserver, valuetype {
Source_Files {
server.cpp
}
}
//-*-server.cpp-*-
#include "TestS.h"
class Test_impl : public POA_ITest
{
public:
CORBA::StringSeq * send_values (const BaseSeq& values) throw
(CORBA::SystemException)
{
CORBA::StringSeq * retval = new CORBA::StringSeq(values.length());
retval->length(values.length());
for(CORBA::ULong c=0; c<values.length(); ++c)
(*retval)[c] = values[c]->_tao_obv_repository_id();
return retval;
}
};
int main (int argc, char* argv[])
{
ACE_DECLARE_NEW_CORBA_ENV;
ACE_TRY
{
CORBA::ORB_var orb = CORBA::ORB_init(argc,argv);
orb->register_value_factory(
Base::_tao_obv_static_repository_id(),
new Base_init);
orb->register_value_factory(
Value::_tao_obv_static_repository_id(),
new Value_init);
CORBA::Object_var poa_object = orb->resolve_initial_references("RootPOA");
if (CORBA::is_nil (poa_object.in ()))
ACE_ERROR_RETURN ((LM_ERROR, " (%P|%t) Unable to initialize the
POA.\n"), 1);
PortableServer::POA_var root_poa = PortableServer::POA::_narrow
(poa_object.in ());
PortableServer::POAManager_var poa_manager = root_poa->the_POAManager();
Test_impl * test = new Test_impl;
ITest_var test_var = test->_this();
CORBA::String_var ior = orb->object_to_string(test_var.in());
FILE *output_file= ACE_OS::fopen ("ior.out", "w");
if (output_file == 0)
ACE_ERROR_RETURN ((LM_ERROR, "Cannot open output file for writing
IOR: ior.out"), 1);
ACE_OS::fprintf (output_file, "%s", ior.in ());
ACE_OS::fclose (output_file);
poa_manager->activate();
orb->run();
orb->destroy();
}
ACE_CATCHANY
{
ACE_PRINT_EXCEPTION (ACE_ANY_EXCEPTION,
"Caught a CORBA exception \n");
return 1;
}
ACE_CATCHALL
{
return 1;
}
ACE_ENDTRY;
ACE_CHECK_RETURN (1);
return 0;
}
//-*-client.cpp-*-
#include "TestC.h"
int main (int argc, char* argv[])
{
ACE_DECLARE_NEW_CORBA_ENV;
ACE_TRY
{
CORBA::ORB_var orb = CORBA::ORB_init(argc,argv);
orb->register_value_factory(
Base::_tao_obv_static_repository_id(),
new Base_init);
orb->register_value_factory(
Value::_tao_obv_static_repository_id(),
new Value_init);
BaseSeq values;
values.length(3);
values[0] = new OBV_Value(1,"An instance of Value");
values[1] = new OBV_Base(2);
values[2] = new OBV_Value(3,"Another instance of Value");
CORBA::Object_var object = orb->string_to_object("file://ior.out");
ITest_var test = ITest::_narrow(object);
CORBA::StringSeq_var repoids = test->send_values(values);
for(CORBA::ULong c=0; c<repoids->length();++c)
{
if (ACE_OS::strcmp( (*repoids)[c].in(),
values[c]->_tao_obv_repository_id()) !=0)
{
ACE_ERROR_RETURN((LM_ERROR,"Error:values[%d] wrong type!\n",c),
1);
}
else
{
ACE_DEBUG((LM_DEBUG,
"values[%d] OK, repository id is '%s'\n",
c,
(*repoids)[c].in() ));
}
}
orb->destroy();
}
ACE_CATCHANY
{
ACE_PRINT_EXCEPTION (ACE_ANY_EXCEPTION,
"Caught a CORBA exception \n");
return 1;
}
ACE_CATCHALL
{
return 1;
}
ACE_ENDTRY;
ACE_CHECK_RETURN (1);
return 0;
}
//-*- result-*-
values[0] OK,repository id is 'IDL:Value:1.0'
values[1] OK,repository id is 'IDL:Base:1.0'
values[2] OK,repository id is 'IDL:Value:1.0'
// -*- Test.idl-*-
#include <orb.idl>
valuetype Base
{
public long l;
};
typedef sequence<Base> BaseSeq;
valuetype Value : Base
{
public string s;
};
interface ITest
{
CORBA::StringSeq send_values(in BaseSeq values);
};
stil valid for 1.5.4 still valid for x.5.8 still valid for 1.6.5, will enable the regression test in our daily suite after x.6.6 is out |
main.cpp:#include "ValueC.h" main.cpp:#include <cassert> main.cpp:#include <iostream> main.cpp:#include <tao/CodecFactory/CodecFactory.h> main.cpp: main.cpp:int main (int argc, char* argv[]) main.cpp:{ main.cpp: CORBA::ORB_var orb = CORBA::ORB_init(argc,argv); main.cpp: main.cpp: orb->register_value_factory( main.cpp: Base::_tao_obv_static_repository_id(), main.cpp: new Base_init); main.cpp: orb->register_value_factory( main.cpp: Value::_tao_obv_static_repository_id(), main.cpp: new Value_init); main.cpp: main.cpp: CORBA::Object_var object = main.cpp: orb->resolve_initial_references("CodecFactory"); main.cpp: main.cpp: IOP::CodecFactory_var codec_factory = main.cpp: IOP::CodecFactory::_narrow(object); main.cpp: IOP::Encoding e = {IOP::ENCODING_CDR_ENCAPS,1,2}; main.cpp: main.cpp: IOP::Codec_var codec = codec_factory->create_codec(e); main.cpp: main.cpp: main.cpp: CORBA::Any any_o; main.cpp: BaseSeq values; main.cpp: values.length(1); main.cpp: values[0] = new OBV_Value(1,"An instance of Value"); main.cpp: any_o <<= values; main.cpp: any_o.type(_tc_BaseSeq); main.cpp: main.cpp: CORBA::OctetSeq_var bin = codec->encode(any_o); main.cpp: CORBA::Any_var any_n = codec->decode(bin); main.cpp: main.cpp: const BaseSeq * out = NULL; main.cpp: assert( any_n.in()>>=out ); main.cpp: assert( strcmp( (*out)[0]->_tao_obv_repository_id(), main.cpp: Value::_tao_obv_static_repository_id()) == 0 main.cpp: ); main.cpp: main.cpp: orb->destroy(); main.cpp: return EXIT_SUCCESS; main.cpp:} Value.idl:valuetype Base Value.idl:{ Value.idl: public long l; Value.idl:}; Value.idl: Value.idl:typedef sequence<Base> BaseSeq; Value.idl: Value.idl:valuetype Value : Base Value.idl:{ Value.idl: public string s; Value.idl:}; test.mpc:project(*) : taoclient ,anytypecode,codecfactory,valuetype{ test.mpc:} ------------------- ./client client: main.cpp:38: int main(int, char**): Assertion `any_n.in()>>=out' failed.