Bug 2704

will handle this

accept, will do this in a few weeks, have locally changes in orb core pending
which i want to get in first

Johnny,

Okay, more on this. In TAO_ORB_Core::init(...) the while loop that parses the 
command line input has the following structure

while(More Argument)
{
  if(OPTION1)
  {
    ...
    arg_shifter.consume_arg ();
  }
  else if(OPTION2)
  {
    ...
    arg_shifter.consume_arg ();
  }
  else if(OPTION3)
  {
    ...
    arg_shifter.consume_arg ();
  }
  .
  .
  .
  else if(OPTIONN)
  {
    ...
    arg_shifter.consume_arg ();
  }
 else
 {
    arg_shifter.ignore_arg ();
 }
}

If we were to change the above to:
while(More Argument)
{
  bool shift = false;

  if(OPTION1)
  {
    ...
    shift = true;
  }
  else if(OPTION2)
  {
    ...
    shift = true;
  }
  else if(OPTION3)
  {
    ...
    shift = true;
  }
  .
  .
  .
  else if(OPTIONN)
  {
    ...
    shift = true;
  }

  if(shift == true)
  {
    arg_shifter.consume_arg ();
    shift = false;
  }
 else
 {
    arg_shifter.ignore_arg ();
 }
}


This minor change results in ~1300 bytes savings ;-)
---------------------------------------------------
size ORB_Core.o 
   text    data     bss     dec     hex filename
  73461     316       6   73783   12037 ORB_Core.o

size libTAO.so
   text    data     bss     dec     hex filename
1243001   41596     248 1284845  139aed libTAO.so

Johnny,

Still in TAO_ORB_Core::init(...). When I change:

else if (0 != (current_arg = arg_shifter.get_the_parameter
         (ACE_TEXT("-ORBDisableRTCollocation"))))
{
  int disable_rt_collocation = ACE_OS::atoi (current_arg);
  if (disable_rt_collocation)
   this->orb_params ()->disable_rt_collocation_resolver (true);
 else
   this->orb_params ()->disable_rt_collocation_resolver (false);

 //arg_shifter.consume_arg ();
 shift = true;
}

To:

else if (0 != (current_arg = arg_shifter.get_the_parameter
         (ACE_TEXT("-ORBDisableRTCollocation"))))
{
  int disable_rt_collocation = ACE_OS::atoi (current_arg);

  this->orb_params ()->disable_rt_collocation_resolver (static_cast<bool>
(disable_rt_collocation));

 //arg_shifter.consume_arg ();
 shift = true;
}

We don't really need to test with if statment if make two calls to 
disable_rt_collocation_resolver. We can just cast the result of atoi to a 
bool, which will effectively do the same thing.

This saves around ~50 bytes. So, we you sum all the changes I proposed, we get 
1338 bytes of savings, which is around %1.8 of ORB_Core.o. I don't know if 
that makes it worthwhile or not, but I thought I'd report it anyway.

size ORB_Core.o 
   text    data     bss     dec     hex filename
  73416     316       6   73738   1200a ORB_Core.o

size libTAO.so
   text    data     bss     dec     hex filename
1242953   41596     248 1284797  139abd libTAO.so

Thanks,
Abdul

I personally don't like the cast, maybe better then use the ? operator or set a
bool first and then call the method once in code?

Hi Johnny,

Sure, either one would work. What I was trying to get across is that since 
some of these methods are inlined, to reduce footprint we should call them 
only when we need to. Thus if we cast, or use ? operator, or convert to 
boolean before hand it will do the trick and save some foot print ;-)

By the way, in ORB_Core.cpp, I think there are 3-4 places where we can do 
this, so we should be able to save another 100 bytes ;-)

Thanks,
Abdul

the consume_arg reduction will work but have to be done carefull, for some flags
we do a consume twice and then we don't have to set this flag

to pool