Summary: | Need to improve support for Interceptors in AMI | ||
---|---|---|---|
Product: | TAO | Reporter: | Nanbor Wang <nanbor> |
Component: | Portable Interceptors | Assignee: | Nanbor Wang <nanbor> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | P3 | ||
Version: | 1.2.5 | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 1369 | ||
Bug Blocks: | 285 | ||
Attachments: | Partial fixes for the bug |
Description
Nanbor Wang
1999-08-30 23:14:22 CDT
Let's work on this at some later point. Created attachment 158 [details]
Partial fixes for the bug
I attached a patch file that mostly fixes this bug. The patch adds interceptors to AMI calls, but the arguments, exceptions and return value are not accessible in the RequestInfo. This satisfies the letter, though not the spirit of the spec. I committed Carlos' patch (updated against latest DOC repo), and updated other non-GNU Make/project files. All that is left is to implement collocated call interceptor support (unrelated to AMI support), and to implement the AMI-specific ClientRequestInfo::{arguments,exceptions,result}() methods. Assuming that the latter won't be completed any time soon, should we mark this bug as fixed? Mon Nov 11 18:03:37 2002 Ossama Othman <ossama@uci.edu> * docs/interceptors.html: Updated release notes about AMI interceptor support. Updated CORBA spec URL to the 3.0.1 spec's URL. * tao/Messaging/Makefile.bor: * tao/Messaging/TAO_Messaging.dsp: * tao/Messaging/TAO_Messaging_Static.dsp: Added AMI_ClientRequestInfo_i.{h,cpp} to these Make/project files. Mon Nov 11 17:27:22 2002 Carlos O'Ryan <coryan@atdesk.com> * tao/Messaging/AMI_ClientRequestInfo_i.h: * tao/Messaging/AMI_ClientRequestInfo_i.cpp: * tao/Messaging/Makefile: Add implementation class for AMI ClientRequestInfos. * TAO_IDL/be/be_codegen.cpp: Move some #includes to the .cpp file, include AMI_ClientRequestInfo_i.h when compiling with interceptors and AMI. * TAO_IDL/be/be_visitor_operation/ami_cs.cpp: Generate interceptor code for sendc_*** operations. * tests/Portable_Interceptors/Makefile: * tests/Portable_Interceptors/AMI/Makefile: * tests/Portable_Interceptors/AMI/run_test.pl: * tests/Portable_Interceptors/AMI/.cvsignore: * tests/Portable_Interceptors/AMI/Client_Interceptor.h: * tests/Portable_Interceptors/AMI/Client_Interceptor.cpp: * tests/Portable_Interceptors/AMI/Client_ORBInitializer.h: * tests/Portable_Interceptors/AMI/Client_ORBInitializer.cpp: * tests/Portable_Interceptors/AMI/Echo.h: * tests/Portable_Interceptors/AMI/Echo.cpp: * tests/Portable_Interceptors/AMI/Echo_Handler.h: * tests/Portable_Interceptors/AMI/Echo_Handler.cpp: * tests/Portable_Interceptors/AMI/Server_Interceptor.h: * tests/Portable_Interceptors/AMI/Server_Interceptor.cpp: * tests/Portable_Interceptors/AMI/Server_ORBInitializer.h: * tests/Portable_Interceptors/AMI/Server_ORBInitializer.cpp: * tests/Portable_Interceptors/AMI/Shared_Interceptor.h: * tests/Portable_Interceptors/AMI/Test.idl: * tests/Portable_Interceptors/AMI/client.cpp: * tests/Portable_Interceptors/AMI/server.cpp: New regression test for the AMI interceptors. This should be fixed in that branch. I need test cases for these This should be fixed now. Merge from 1369 should have taken care of this Tue Oct 28 12:02:47 2003 Balachandran Natarajan <bala@dre.vanderbilt.edu> A typo. Merge from 1369 "has" taken care o fthis instead of "should have".. |