Bug 3885 - Normalize the use of command, commandflags, and quoting
Summary: Normalize the use of command, commandflags, and quoting
Status: NEW
Alias: None
Product: MPC
Classification: Unclassified
Component: MPC (show other bugs)
Version: unspecified
Hardware: All All
: P3 enhancement
Assignee: Chris Cleeland
URL:
Depends on:
Blocks:
 
Reported: 2010-08-31 15:36 CDT by Adam Mitz
Modified: 2011-01-07 09:25 CST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Mitz 2010-08-31 15:36:27 CDT 
Now that bug #3811 is fixed, we should be able to make all uses of Define_Custom commands consistent such that they don't need an explicit <%quote%> to get the correct handling of commands that may have spaces (or variables that expand to include spaces).  The rule would be that "command" contains the file name (and optional path) of a single executable file.  Anything else goes in "commandflags".  That way each template could handle adding the right kind of quotes around the command.
ndds_ts_defaults.mpb and opalorb.mpb (both in $MPC_ROOT/config) appear to be the only two that would need to change to make this work.  I didn't find any mpbs in the usual locations for ACE, TAO, CIAO, DANCE, and OpenDDS that would need to be changed.
On the template side I think gnuace already handles it (but we should test to confirm), and the vc* templates would need to change.
Comment 1 Adam Mitz 2011-01-07 09:25:16 CST 
At the same time this is done, we could add a "description" field to the Define_Custom.  The use for this is primarily for the IDE-based projects.  Currently when we run a perl script as the command, the project has
Description="Invoking perl on foo.input"
so that's what shows up in the build output.  The new "description" field would allow the .mpb author to give it a more meaningful message.