Bug 2498 - Investigate making ORB_Core argument of TAO_InputCDR a reference
Summary: Investigate making ORB_Core argument of TAO_InputCDR a reference
Status: ASSIGNED
Alias: None
Product: TAO
Classification: Unclassified
Component: ORB (show other bugs)
Version: 1.5
Hardware: All All
: P3 normal
Assignee: DOC Center Support List (internal)
URL:
Depends on:
Blocks:
 
Reported: 2006-04-06 13:46 CDT by Johnny Willemsen
Modified: 2006-04-10 03:19 CDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johnny Willemsen 2006-04-06 13:46:14 CDT 
found during valuetype changes. we do store a ORB_Core* in TAO_InputCDR. In
several places in the code we have a fallback when this pointer is 0, then we
get the orb instance. We should look if we can make this argument a ORB_Core& so
that we can remove the fallback for a 0 pointer in several places throughout
TAO. This will mean we have to change the order of the arguments of the
TAO_InputCDR constructors.
Comment 1 Johnny Willemsen 2006-04-10 03:19:33 CDT 
a quick test showed that changing this in input_cdr will cause interface changes
throughout the core libs in all areas. The orb_core is passed through a lot of
constructors and methods, in about 95% of the cases there is no check at all if
the orb_core pointer is passed could be zero. Changing it to a reference will
make it really clar the orb_core must always be there. We should make this
change after all branches are merged to cvs head because this impacts too much
classes at this moment to also put under a branch.